HCaptcha support. #5953
HCaptcha support. #5953
Conversation
| HCaptchaConfig.builder() | ||
| .siteKey("f1f21d64-6384-4114-b7d0-d9d23e203b4a") | ||
| .theme(if (WikipediaApp.instance.currentTheme.isDark) HCaptchaTheme.DARK else HCaptchaTheme.LIGHT) | ||
| .host("meta.wikimedia.org") |
There was a problem hiding this comment.
The WebView popped up by the hCaptcha SDK requires a base URL that matches our content-security-policy, otherwise the iframe inside the WebView will refuse to load the hcaptcha content.
| .endpoint("https://hcaptcha.wikimedia.org") | ||
| .assethost("https://assets-hcaptcha.wikimedia.org") | ||
| .imghost("https://imgs-hcaptcha.wikimedia.org") | ||
| .reportapi("https://report-hcaptcha.wikimedia.org") |
There was a problem hiding this comment.
(todo: all the above parameters will be served up via our new remote configuration endpoint)
| private var hCaptcha: HCaptcha? = null | ||
| private var tokenResponse: HCaptchaTokenResponse? = null | ||
|
|
||
| private val configDefault get() = RemoteConfig.RemoteConfigHCaptcha( |
There was a problem hiding this comment.
Note: even though these parameters are served by our remote configuration, we still want to hardcode some defaults here, in case the network call to fetch remote configuration fails.
cooltey
left a comment
cooltey
left a comment
There was a problem hiding this comment.
Could not be able to test this because of the error code sitekey-mismatch
| imgHost = "https://imgs-hcaptcha.wikimedia.org", | ||
| reportApi = "https://report-hcaptcha.wikimedia.org", | ||
| sentry = false, | ||
| siteKey = "e11698d6-51ca-4980-875c-72309c6678cc" |
There was a problem hiding this comment.
Looks like the siteKey is outdated?
There was a problem hiding this comment.
Hmm curious, looking into this with the other team...
There was a problem hiding this comment.
This should be fixed now on the backend.
app/src/main/java/org/wikipedia/createaccount/CreateAccountActivity.kt
Outdated
Show resolved
Hide resolved
dbrant
added
HOLD
dbrant
removed
the
HOLD
dbrant
added
the
HOLD
4 participants
https://phabricator.wikimedia.org/T379190